Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Webots and libcontroller version comparison #6315

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Improve Webots and libcontroller version comparison #6315

merged 2 commits into from
Jul 10, 2023

Conversation

ygoumaz
Copy link
Contributor

@ygoumaz ygoumaz commented Jul 10, 2023

Only the major version number should be compared. Revisions should not break the compatibility between Webots and the controller library.

@ygoumaz ygoumaz self-assigned this Jul 10, 2023
@ygoumaz ygoumaz added cleanup Any design, code, file or folder cleanup bug Something isn't working labels Jul 10, 2023
@ygoumaz ygoumaz added this to the R2023b-rev1 milestone Jul 10, 2023
@ygoumaz ygoumaz marked this pull request as ready for review July 10, 2023 12:06
@ygoumaz ygoumaz requested a review from a team as a code owner July 10, 2023 12:06
@ygoumaz ygoumaz requested a review from omichel July 10, 2023 12:06
omichel
omichel approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@ygoumaz ygoumaz merged commit 3cf515d into master Jul 10, 2023
20 checks passed
@ygoumaz ygoumaz deleted the fix-webots-libcontroller-version-comparison branch July 10, 2023 13:43
@ygoumaz ygoumaz mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omichel omichel omichel approved these changes

Assignees

@ygoumaz ygoumaz

Labels
bug Something isn't working cleanup Any design, code, file or folder cleanup
Milestone
R2023b-rev1
Development

Successfully merging this pull request may close these issues.
2 participants
@ygoumaz @omichel