Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make supervisor_export_image use FBO instead of screen framebuffer. #6622

Merged

Conversation

brettle
Copy link
Contributor

@brettle brettle commented Aug 14, 2024

Description

This makes the supervisor_export_image test pass under Wayland and has the added benefit of making that test (and the billboard test) work with "--no-rendering --minimize". As a result those tests are moved into the api group and the with_rendering group is removed.

Tasks
Add the list of tasks of this PR.

This makes the supervisor_export_image test pass under Wayland and has the added benefit of making that test (and the billboard test) work with "--no-rendering --minimize". As a result those tests are moved into the api group and the with_rendering group is removed.
@brettle brettle requested a review from a team as a code owner August 14, 2024 21:44
@brettle brettle added the test suite Start the test suite label Aug 14, 2024
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.
Thank you.

@brettle brettle merged commit 0ee2580 into cyberbotics:master Aug 15, 2024
36 of 39 checks passed
@brettle brettle deleted the fix-export-image-pickiness branch August 15, 2024 18:35
brettle added a commit to DeepBlueRobotics/webots that referenced this pull request Aug 26, 2024
brettle added a commit to DeepBlueRobotics/webots that referenced this pull request Aug 26, 2024
brettle added a commit that referenced this pull request Aug 26, 2024
…PixelRatio != 1. (#6638)

* Fix bug (introduced in PR #6622) when grabbing with devicePixelRatio != 1.

* Fix video recording size bug introduced by PR #6622.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test suite Start the test suite
Development

Successfully merging this pull request may close these issues.

2 participants