-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mostly MacOS-related fixes #6635
Merged
brettle
merged 19 commits into
cyberbotics:master
from
DeepBlueRobotics:fix-macos-build-by-user
Aug 25, 2024
Merged
Mostly MacOS-related fixes #6635
brettle
merged 19 commits into
cyberbotics:master
from
DeepBlueRobotics:fix-macos-build-by-user
Aug 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port compilation across SDK versions.
…alid argument" error on MacOS.
…secondary windows, so that sharing will be successful. On MacOS, the format used by a context is not necessarily the same as the one requested.
brettle
changed the title
Don't require admin privs for as much on MacOS
MacOS-related fixes
Aug 23, 2024
omichel
approved these changes
Aug 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
This PR is small, so it is OK to have several unrelated fixes in it, but in general we prefer to have one fix per PR. That is easier to review and useful to track down bugs afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are changes I needed to run make and test_suite.py on my MacOS laptop as a regular user without it crashing.
At least one test (
supervisor_export_image
) still fails for me on MacOS but at least the test suite now runs without crashing.Notable user-visible changes:
check_saved_hidden_parameters.wbt
.mirror.wbt
test). This was caused by using different formats for the different windows.There are also some minor changes that are not user-visible:
(mach_port_t)NULL
because it is equivalent to kIOMainPortDefault or kIOMasterPortDefault but works across SDK versions.aqt
in a python virtual env.test_suite.py
use a new socket for each retry.