Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mostly MacOS-related fixes #6635

Merged
merged 19 commits into from
Aug 25, 2024

Conversation

brettle
Copy link
Contributor

@brettle brettle commented Aug 20, 2024

Description

These are changes I needed to run make and test_suite.py on my MacOS laptop as a regular user without it crashing.

At least one test (supervisor_export_image) still fails for me on MacOS but at least the test suite now runs without crashing.

Notable user-visible changes:

  • Fixed connection errors when using long robot names in some environments (issue Long non-ASCII robot name crashes the controller. #5452). This is not MacOS specific but is more likely to occur on a Mac because it's max socket path length is shorter than on Linux.
  • Fixed crash on MacOS when quitting under some circumstances. One reproducible case was quitting after running check_saved_hidden_parameters.wbt.
  • Fixed error when putting displays and cameras in separate windows on MacOS (e.g. with the mirror.wbt test). This was caused by using different formats for the different windows.

There are also some minor changes that are not user-visible:

  • Use (mach_port_t)NULL because it is equivalent to kIOMainPortDefault or kIOMasterPortDefault but works across SDK versions.
  • Run aqt in a python virtual env.
  • Make test_suite.py use a new socket for each retry.

@brettle brettle added the test webots build Start the build tests label Aug 20, 2024
@brettle brettle changed the title Don't require admin privs for as much on MacOS MacOS-related fixes Aug 23, 2024
@brettle brettle changed the title MacOS-related fixes Mostly MacOS-related fixes Aug 25, 2024
@brettle brettle marked this pull request as ready for review August 25, 2024 02:06
@brettle brettle requested a review from a team as a code owner August 25, 2024 02:06
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
This PR is small, so it is OK to have several unrelated fixes in it, but in general we prefer to have one fix per PR. That is easier to review and useful to track down bugs afterwards.

@brettle brettle merged commit 3485871 into cyberbotics:master Aug 25, 2024
20 checks passed
@brettle brettle deleted the fix-macos-build-by-user branch August 25, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test webots build Start the build tests
Development

Successfully merging this pull request may close these issues.

2 participants