Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test suite on windows during CI #6648

Merged

Conversation

brettle
Copy link
Contributor

@brettle brettle commented Aug 31, 2024

Description
Run test suite on windows during CI.

Includes PR #6631.

6.4.3 is no longer supported, while 6.5.3 is the latest LTS release and is supported through 31 Mar 2026.

For this to work, the precompiled binaries at https://cyberbotics.com/files/repository/dependencies/ will need to be updated but I don't think I have the ability to do that.
@brettle
Copy link
Contributor Author

brettle commented Sep 9, 2024

Although this PR currently works in CI, I'm getting a likely unrelated crash on my local machine when running:

./tests/test_suite.py --group api tests/api/worlds/robot_urdf.wbt  tests/api/worlds/supervisor_set_hinge_position_dynamic.wbt

The robot_urdf test passes but then there is a crash when running the second test. The problem goes away if I remove the --minimize at test_suite.py:246.

Still investigating but if anyone else can let me know whether or not they can reproduce it, that would be good to know.

@brettle
Copy link
Contributor Author

brettle commented Sep 11, 2024

Still investigating but if anyone else can let me know whether or not they can reproduce it, that would be good to know.

Further investigation indicates that the crash is unrelated to any changes in this PR. I'll file a separate issue for it.

@brettle brettle marked this pull request as ready for review September 11, 2024 23:36
@brettle brettle requested a review from a team as a code owner September 11, 2024 23:36
@brettle
Copy link
Contributor Author

brettle commented Sep 11, 2024

This is now ready for review.

Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@brettle brettle merged commit 34dfe53 into cyberbotics:master Sep 12, 2024
23 checks passed
@brettle brettle deleted the fix-test-suite-not-run-on-windows branch September 12, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test suite Start the test suite
Development

Successfully merging this pull request may close these issues.

3 participants