Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when using muscles and animatedGeometry in sequential worlds. #6661

Conversation

brettle
Copy link
Contributor

@brettle brettle commented Sep 16, 2024

Description

The issue was that WbWrenVertexArrayFrameListener thought that the frame had already been handled because it had been handled in the previous world.

Related Issues
This pull-request fixes issue #6659

Tasks

No changelog update because the issue did not exist in R2023a.

The issue was that WbWrenVertexArrayFrameListener thought that the frame had already been handled because it had been handled in the previous world.
@brettle brettle marked this pull request as ready for review September 16, 2024 17:20
@brettle brettle requested a review from a team as a code owner September 16, 2024 17:20
@brettle brettle added the test suite Start the test suite label Sep 16, 2024
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you.

@brettle brettle merged commit 3c4a3c0 into cyberbotics:master Sep 16, 2024
23 checks passed
@brettle brettle deleted the fix-crash-when-using-muscles-and-animated-geometry-in-sequential-worlds branch September 16, 2024 19:50
omichel added a commit that referenced this pull request Sep 17, 2024
…s. (#6661) (#6662)

* Fix crash when using muscles and animatedGeometry in sequential worlds.

The issue was that WbWrenVertexArrayFrameListener thought that the frame had already been handled because it had been handled in the previous world.

* Add test case.

Co-authored-by: Dean Brettle <dean@brettle.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
omichel added a commit that referenced this pull request Sep 18, 2024
…s. (#6661) (#6663)

* Fix crash when using muscles and animatedGeometry in sequential worlds.

The issue was that WbWrenVertexArrayFrameListener thought that the frame had already been handled because it had been handled in the previous world.

* Add test case.

Co-authored-by: Dean Brettle <dean@brettle.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
omichel added a commit that referenced this pull request Sep 19, 2024
…s. (#6661) (#6664)

* Fix crash when using muscles and animatedGeometry in sequential worlds.

The issue was that WbWrenVertexArrayFrameListener thought that the frame had already been handled because it had been handled in the previous world.

* Add test case.

Co-authored-by: Dean Brettle <dean@brettle.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test suite Start the test suite
Development

Successfully merging this pull request may close these issues.

2 participants