Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe floating point sum on aggregates rebuild #250

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

antonkomarev
Copy link
Member

This code may lead to float issues.

$totalWeight += $counter->getWeight();

@antonkomarev antonkomarev added this to the v10.0 milestone Apr 9, 2023
@antonkomarev antonkomarev modified the milestones: v10.0, v11.0 Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant