initial commit of tabs #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ratkaise noi ristiriidat, jotta chromatic buildais |
Hartzi
reviewed
Aug 22, 2023
src/components/Tab/Tab.tsx
Outdated
| /** | ||
| * Tab styles | ||
| */ | ||
| const TabContainer = styled.div<TabProps>` |
There was a problem hiding this comment.
Mä olin figmassa käyttäny tässä buttonia, jonka olin nimenny TabButtoniksi ja vaihdoin vain tasutaväriä. Eikös sama toimis tässä, niin ei tarvi muuta tyylittelyä tehdä?
There was a problem hiding this comment.
Tämän tosiaan muuttaisin buttonin text-variantiksi, niin ei tarvi samaa asiaa tehdä kahteen kertaan. Toki taustaväri tarvii siihen muuttaa.
Hartzi
reviewed
Aug 22, 2023
Hartzi
reviewed
Aug 22, 2023
Hartzi
reviewed
Sep 1, 2023
src/components/Tabs/Tabs.stories.tsx
Outdated
Comment on lines
31
to
57
| const Template: StoryFn<typeof Tabs> = (args) => ( | ||
| <Tabs {...args} aria-label='Example tabs component'> | ||
| <Tab label='Tab' /> | ||
| </Tabs> | ||
| ); | ||
| const ActiveTabTemplate: StoryFn<typeof Tabs> = (args) => ( | ||
| <Tabs {...args} aria-label='Example tabs component'> | ||
| <Tab active label='Tab' /> | ||
| <Tab label='Tab' /> | ||
| <Tab label='Tab' /> | ||
| </Tabs> | ||
| ); | ||
| const Wrapper = styled.div<TabsProps>` | ||
| width: ${pxToRem(400)}; | ||
| `; | ||
| const ScrollTabTemplate: StoryFn<typeof Tabs> = (args) => ( | ||
| <Wrapper> | ||
| <Tabs {...args} aria-label='Example tabs component'> | ||
| <Tab active label='Tab' /> | ||
| <Tab label='Tab' /> | ||
| <Tab label='Tab' /> | ||
| <Tab label='Tab' /> | ||
| <Tab label='Tab' /> | ||
| <Tab label='Tab' /> | ||
| </Tabs> | ||
| </Wrapper> | ||
| ); |
There was a problem hiding this comment.
Näissä vois olla tilanhallinta, jotta aktiivinen välilehti vaihtuisi klikkaamalla
Hartzi
reviewed
Sep 1, 2023
src/components/Tab/Tab.tsx
Outdated
| disabled={disabled} | ||
| id={componentId} | ||
| active={active} | ||
| {...restprops} |
There was a problem hiding this comment.
Tyylillisesti vois olla viimeisenä tässä listauksessa
Hartzi
reviewed
Sep 1, 2023
src/components/Tabs/Tabs.tsx
Outdated
| /** | ||
| * Returned component | ||
| */ | ||
| export const Tabs = ({ value, children, id, ...restprops }: TabsProps) => { |
There was a problem hiding this comment.
Täältä pitäs varmaan saada onChange ulos myös?
MikkoLuhtasaari
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.