Feature/notification carousel #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also fixed excess height bug in Notification if there is no message
This comment was marked as resolved.
This comment was marked as resolved.
Hartzi
reviewed
Sep 1, 2023
- Also making sure pointer events pass thru the transparent area of the div which contains the notifications with spacing
Hartzi
reviewed
Sep 4, 2023
Hartzi
reviewed
Sep 4, 2023
- Moved NotificationCarouselItemWrapper inside TimedNotification, so that hidden notifications don't cause extra padding (bug)
- True deletion from the list (timed or close button, not just hiding) works now all way from the original Notification component with help of a new callback
Hartzi
reviewed
Sep 8, 2023
Hartzi
approved these changes
Sep 8, 2023
ksalin
force-pushed
the
feature/notification-carousel
branch
from
03581a3 to
c11a6ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version after some ideas in daily meeting. The story demonstrates a situation where there are three notifications in a vertically size limited carousel, and the last notification becomes fully visible when the timed notification disappears before it. The notifications can be also manually dismissed by the close button. The carousel could be placed in a corner of a web site for example with Floating UI.