Homework3 completed #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦞 Scrapper code coverage
|
yrlvdplsh
reviewed
Apr 15, 2024
bot/src/main/java/edu/java/bot/controller/RestControllerAdvice.java
Outdated
Show resolved
Hide resolved
| import org.springframework.web.reactive.function.client.WebClient; | ||
|
|
||
| public class WebClientScrapperClient implements ScrapperClient { | ||
| private final static String DEFAULT_BASE_URL = "http://127.0.0.1:8080"; |
There was a problem hiding this comment.
Лучше в пропсы вынести, представь, что у тебя несколько конфигов-для локальных запусков, тестовый и продовый. В целом так лучше поступать со всеми эндпоинтами.
There was a problem hiding this comment.
Я решил все-таки оставить тут этот BASE URL, а создание бина перенес в файл конфигурации, чтобы можно было задавать url в конфиге, надеюсь, так можно)
@Configuration
public class ClientConfiguration {
@Bean
public ScrapperClient scrapperClient(ApplicationConfig config) {
return new WebClientScrapperClient(config.scrapperUrl());
}
}# Conflicts: # scrapper/src/main/java/edu/java/clients/stackoverflow/StackOverflowClient.java # scrapper/src/main/java/edu/java/clients/stackoverflow/StackOverflowWebClient.java # scrapper/src/test/java/edu/java/scrapper/clients/stackoverflow/StackOverflowWebClientTest.java
🤖 Bot code coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Сделал третью домашнюю работу.
В этой работе:
Сейчас продумываю идеи для тестов, чувствую, что тут идеально подойдут айтишники, но пока не знаю, как их делать.