Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement POST /metric & PATCH /metric to web-UI #119

Closed
3 tasks done
denys-holub opened this issue Feb 21, 2023 · 4 comments · Fixed by #120
Closed
3 tasks done

implement POST /metric & PATCH /metric to web-UI #119

denys-holub opened this issue Feb 21, 2023 · 4 comments · Fixed by #120
Assignees
@pashagolub @denys-holub
Labels
epic Large body of work broken down into a number of smaller issues webui Admin UI related issues
Milestone
Built-in WebUI

Comments

@denys-holub
Copy link
Collaborator

denys-holub commented Feb 21, 2023 •
edited
Loading

  • create modal form for creating/editing metrics
  • implement POST /metric
  • implement PATCH /metric
@denys-holub denys-holub added epic Large body of work broken down into a number of smaller issues webui Admin UI related issues labels Feb 21, 2023
@denys-holub denys-holub added this to the Built-in WebUI milestone Feb 21, 2023
@denys-holub denys-holub self-assigned this Feb 21, 2023
@pashagolub pashagolub self-assigned this Feb 21, 2023
@denys-holub
Copy link
Collaborator Author

Describe the bug
Something wrong with editing a metric. pq: syntax error at or near "("

To Reproduce

  1. Go to Metric definitions tab
  2. Click on any metric Edit
  3. Click Submit button (you can try to change some fields, but it's not necessary)
  4. See error

Expected behavior
Metric must be updated, success alert must be shown

Screenshots
image

@pashagolub
Copy link
Collaborator

@denys-holub Would you please set fixed height for all columns in all grids
image

@denys-holub
Copy link
Collaborator Author

@pashagolub set fixed height for all columns in all grids
image

@pashagolub
Copy link
Collaborator

ready for PR

@denys-holub denys-holub linked a pull request Feb 22, 2023 that will close this issue
[+] implement POST /metric & PATCH /metric to web UI, closes #119 #120
Merged
pashagolub added a commit that referenced this issue Feb 22, 2023
@denys-holub @pashagolub
[+] implement POST /metric & PATCH /metric to web UI, closes #119 (…
aa176e6 
…#120)

Co-authored-by: Pavlo Golub <pavlo.golub@gmail.com>
@krisavi krisavi mentioned this issue Jul 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pashagolub pashagolub

@denys-holub denys-holub

Labels
epic Large body of work broken down into a number of smaller issues webui Admin UI related issues
Projects
None yet
Milestone
Built-in WebUI
Development

Successfully merging a pull request may close this issue.

[+] implement POST /metric & PATCH /metric to web UI, closes #119 cybertec-postgresql/pgwatch
2 participants
@pashagolub @denys-holub