Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres-continuous-discovery source produces duplicate outputs #554

Closed
kmoppel opened this issue Oct 5, 2024 · 1 comment
Closed

postgres-continuous-discovery source produces duplicate outputs #554

kmoppel opened this issue Oct 5, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@kmoppel
Copy link
Contributor

kmoppel commented Oct 5, 2024

Seems some unnecessary duplication going on, as in the below case the "public.pgbench_accounts_ts_hash" table only exists in the "postgres" database in reality

pwatch output:

$ curl -s localhost:9188/ | grep pgbench_accounts_ts_hash | grep n_live
pgwatch_table_stats_n_live_tup{dbname="test1_bench",schema="public",table_full_name="public.pgbench_accounts_ts_hash",table_name="pgbench_accounts_ts_hash",table_size_cardinality_mb="0"} 0 1728115109486
pgwatch_table_stats_n_live_tup{dbname="test1_pgwatch2_metrics",schema="public",table_full_name="public.pgbench_accounts_ts_hash",table_name="pgbench_accounts_ts_hash",table_size_cardinality_mb="0"} 0 1728115109480
pgwatch_table_stats_n_live_tup{dbname="test1_postgres",schema="public",table_full_name="public.pgbench_accounts_ts_hash",table_name="pgbench_accounts_ts_hash",table_size_cardinality_mb="0"} 0 1728115109474

pgwatch2 output in same mode:

$ curl -s localhost:9187/ | grep pgbench_accounts_ts_hash | grep n_live
pgwatch2_table_stats_n_live_tup{dbname="adhoc_postgres",schema="public",table_full_name="public.pgbench_accounts_ts_hash",table_name="pgbench_accounts_ts_hash",table_size_cardinality_mb="0"} 0 1728115333370
@pashagolub pashagolub self-assigned this Oct 14, 2024
@pashagolub pashagolub added the bug Something isn't working label Oct 14, 2024
@pashagolub
Copy link
Collaborator

Thanks Kaarel! I found the problem. It's not prometheus related but resolver related

@pashagolub pashagolub changed the title Prometheus + postgres-continuous-discovery mode produces duplicate outputs postgres-continuous-discovery source produces duplicate outputs Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants