Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[-] remove passwords from sink log messages, fixes #612 #614

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[-] remove passwords from sink log messages, fixes #612 #614

merged 1 commit into from
Jan 9, 2025

Conversation

pashagolub
Copy link
Collaborator

No description provided.

@pashagolub pashagolub linked an issue Jan 9, 2025 that may be closed by this pull request
Masking passwords in PGWatch Logs #612
Closed
@pashagolub pashagolub self-assigned this Jan 9, 2025
@pashagolub pashagolub added bug Something isn't working sinks Where and how to store monitored data security Security related issues labels Jan 9, 2025
@pashagolub pashagolub merged commit f3f11f1 into master Jan 9, 2025
8 checks passed
@pashagolub pashagolub deleted the 612-masking-passwords-in-pgwatch-logs branch January 9, 2025 12:03
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12688859751

Details

  • 18 of 24 (75.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 28.823%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/sinks/postgres.go 4 7 57.14%
internal/sinks/prometheus.go 0 3 0.0%
Totals Coverage Status
Change from base Build 12598801562: 0.06%
Covered Lines: 1410
Relevant Lines: 4892
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pashagolub pashagolub

Labels
bug Something isn't working security Security related issues sinks Where and how to store monitored data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Masking passwords in PGWatch Logs
2 participants
@pashagolub @coveralls