Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor adding database to monitoring modal window, closes #52 #64

Merged
merged 12 commits into from
Dec 5, 2022
Merged

refactor adding database to monitoring modal window, closes #52 #64

merged 12 commits into from
Dec 5, 2022

Conversation

Lana8Lee
Copy link
Member

@Lana8Lee Lana8Lee commented Dec 2, 2022

Added tabs to the modal window. Filled tab 'main' with necessary inputs.

@Lana8Lee Lana8Lee linked an issue Dec 2, 2022 that may be closed by this pull request
refactor adding database to monitoring modal window #52
Closed
6 tasks
@pashagolub
Copy link
Collaborator

Nice. Would you please share some screenshots? :) So one can see the changes without actually building and running new functionality

@Lana8Lee
Copy link
Member Author

Lana8Lee commented Dec 2, 2022 •
edited
Loading

Nice. Would you please share some screenshots? :) So one can see the changes without actually building and running new functionality

Please, do not merge so far :)
It's a draft to see intermediate changes.
@denys-holub will add screenshots after all

@denys-holub denys-holub force-pushed the 52-refactor-adding-database-to-monitoring-modal-window branch from d0bc901 to 334caae Compare December 5, 2022 08:46
@pashagolub pashagolub self-assigned this Dec 5, 2022
@pashagolub pashagolub added enhancement New feature or request webui Admin UI related issues labels Dec 5, 2022
@pashagolub pashagolub added this to the Built-in WebUI milestone Dec 5, 2022
@denys-holub
Copy link
Collaborator

Here are screenshots.

main
connection
ssl
presets

@pashagolub pashagolub marked this pull request as ready for review December 5, 2022 12:12
pashagolub
pashagolub approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@pashagolub pashagolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job! 🎉

@pashagolub pashagolub changed the title Web UI refactor adding database to monitoring modal window, closes #52 Dec 5, 2022
@pashagolub pashagolub force-pushed the 52-refactor-adding-database-to-monitoring-modal-window branch from 9ed9f69 to 5960c89 Compare December 5, 2022 12:21
denys-holub and others added 12 commits December 5, 2022 13:22
@pashagolub pashagolub force-pushed the 52-refactor-adding-database-to-monitoring-modal-window branch from 5960c89 to 2244ae1 Compare December 5, 2022 12:22
@pashagolub pashagolub merged commit 6cda65e into master Dec 5, 2022
@pashagolub pashagolub deleted the 52-refactor-adding-database-to-monitoring-modal-window branch December 5, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pashagolub pashagolub pashagolub approved these changes

Assignees

@pashagolub pashagolub

Labels
enhancement New feature or request webui Admin UI related issues
Projects
None yet
Milestone
Built-in WebUI
Development

Successfully merging this pull request may close these issues.

refactor adding database to monitoring modal window
3 participants
@Lana8Lee @pashagolub @denys-holub