-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate v1 and v2alpha1 SubNamespace API #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think v1 should be deplicate after releasing v2 or v2beta1.
If v1 is deplicate, users will not be able to decide which version to use.
Agree! Any more we want to adjust before v2 is finalized? I don't see anything missing from SubNamespace v2 API. |
@erikgb |
Should we just skip a beta-version of the API and go directly for v2? WDYT? |
I think it's fine to skip beta and go directly to v2. |
Thanks, I will do the work required. Marking this PR as a draft for now. |
9cfc2db
to
915ff1d
Compare
@zoetrope A gentle ping for a review of this PR. 🙏 I also have other open unreviewed PRs. 🙏 We prefer if a new release is cut as soon as possible. 🤠 |
@erikgb |
The v2alpha1 version of the SubNamespace API has been available for a while, and I think it's time to consider deprecating the v1 version. The newer version has a much better observed state UX with conditions. We should probably make v2 (or v2beta1) available - to not "scare" our users from migrating (to an alpha version).