fix: improve CRD install (Helm and standalone) #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgb
force-pushed
the
fix-install-crds
branch
2 times, most recently
from
ae172a4
to
1b2c825
Compare
zoetrope
reviewed
Jul 5, 2024
zoetrope
reviewed
Jul 5, 2024
zoetrope
previously approved these changes
Jul 5, 2024
|
@zoetrope Conflicts should be resolved now. I also removed your two commits. They appeared to be a no-op in total. 😉 |
zoetrope
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is twofold: fix the currently broken CRDs standalone install (#139) and improve the Helm CRDs install by adding
helm.sh/resource-policy: keepannotation (by default) to CRDs to prevent Helm from uninstalling the CRD when the Helm release is uninstalled. The general improvement of Helm CRD install will hopefully allow more users to let Helm manage CRDs.I will suggest publishing CRDs as a release artifact to avoid the new
crd-onlykustomize overlay. As long as we have conversion webhooks, installing CRDs separately will be somehow borked.The solution is heavily inspired by recent work in cert-manager!
Fixes #139