Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): correct invalid ConfigMap template #143

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Jul 5, 2024

This corrects a bug in #142. Without this fix, the Helm chart rendering is erroring out with:

Error: Error: template: accurate/templates/deployment.yaml:18:28: executing "accurate/templates/deployment.yaml" at <include (print $.Template.BasePath "/configmap.yaml") .>: error calling include: template: accurate/templates/configmap.yaml:24:20: executing "accurate/templates/configmap.yaml" at <.Values.controller.config.propagateLabelKeyExcludes>: can't evaluate field Values in type []interface {}

Sorry for this, but this is a blocking error that will require a new patch release (of the Helm chart, at least).

CC @zoetrope @ymmt2005

Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymmt2005 ymmt2005 merged commit 839664e into cybozu-go:main Jul 5, 2024
8 checks passed
@ymmt2005
Copy link
Member

ymmt2005 commented Jul 5, 2024

@zoetrope please release a new Helm chart. Thank you.

@zoetrope zoetrope added the bug Something isn't working label Jul 8, 2024
@zoetrope
Copy link
Member

zoetrope commented Jul 8, 2024

@erikgb @ymmt2005
Thanks.
https://github.com/cybozu-go/accurate/releases/tag/accurate-chart-0.7.5 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants