Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete 'OnDelete' DaemonSet pods #746

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Delete 'OnDelete' DaemonSet pods #746

merged 2 commits into from
Jun 27, 2024

Conversation

tkna
Copy link
Contributor

@tkna tkna commented Jun 25, 2024

This PR adds the ability to delete Daemonset pods set to updateStrategy: OnDelete before rebooting.

@tkna tkna self-assigned this Jun 25, 2024
Signed-off-by: naoki-take <naoki-take@cybozu.co.jp>
@tkna tkna force-pushed the delete-daemonset-ondelete-pods branch from a557b9b to 131033c Compare June 25, 2024 09:34
@tkna tkna marked this pull request as ready for review June 25, 2024 09:35
@tkna tkna requested a review from yokaze June 25, 2024 09:35
Copy link
Contributor

@yokaze yokaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just deleting the pods? I doubt we need to evict the DaemonSet pods.

Signed-off-by: naoki-take <naoki-take@cybozu.co.jp>
@tkna tkna requested a review from yokaze June 26, 2024 07:59
Copy link
Contributor

@yokaze yokaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkna tkna changed the title Evict 'OnDelete' DaemonSet pods Delete 'OnDelete' DaemonSet pods Jun 27, 2024
@tkna tkna merged commit 72df03b into main Jun 27, 2024
7 checks passed
@tkna tkna deleted the delete-daemonset-ondelete-pods branch June 27, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants