Change MB expire strategy #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshipp
force-pushed
the
mb-expire
branch
3 times, most recently
from
e50469b
to
37b8a40
Compare
We designed MantleBackupConfig expires MantleBackup, but it was not good because replicated MantleBackups on the secondary will not be able to expired if the primary and the secondary are disconnected. To fix this, we introduce Expire on the MB itself. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
The expiration duration can now be given in the MB spec, set it according to MBC spec. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
MantleBackup can be created manually, so it's not necessary to inherit validation from MantleBackupConfig. However, there's no reason to change it, so we'll use the same validation. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
It intends to replace executeCommand in mantlebackup_controller. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
The previous code simulates the executeCommand function and sets static timestamps for RBD snapshots. This approach poses a problem for implementing expiration, as all MantleBackup resources would expire during testing if the timestamps become outdated. To address this, we need to create a more realistic fake CephCmd and use it. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
The expiration is done by reconciler if already expired. Otherwise schedule expiration by requesting GenericEvents instead of using requeue provided by controller-runtime. It is because we don't want to exit the reconciler to do other tasks. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
It should be also implemented in MB reconciler as well as expiration. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
The expiration is done by MB reconciler, delete the function from the sub command. Now the command name becomes backup. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We designed MBC to handle the expiration of backups, but it is not good because MBC does not delete secondary MB if the network connection is disconnected. To fix this, we add an expire field to MB.