Skip to content

Commit

Permalink
update dep
Browse files Browse the repository at this point in the history
  • Loading branch information
takara9 committed May 17, 2024
1 parent 9c91adf commit ac1dfbd
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 12 deletions.
4 changes: 2 additions & 2 deletions .github/actions/aqua/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ inputs:
runs:
using: composite
steps:
- uses: aquaproj/aqua-installer@6ce1f8848ec8e61f14d57bd5d7597057a6dd187c # v2.28.0
- uses: aquaproj/aqua-installer@4551ec64e21bf0f557c2525135ff0bd2cba40ec7 # v3.0.0
with:
aqua_version: v2.28.0
aqua_version: v2.25.2
env:
GITHUB_TOKEN: ${{ inputs.github_token }}
16 changes: 11 additions & 5 deletions cmd/sub/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import (
"sigs.k8s.io/controller-runtime/pkg/healthz"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
"sigs.k8s.io/controller-runtime/pkg/webhook"
)

var (
Expand All @@ -26,13 +28,17 @@ func run(addr string, port int, profs []hooks.SecurityProfile) error {
ctrl.SetLogger(zap.New(zap.UseFlagOptions(&config.zapOpts)))

mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
Scheme: scheme,
MetricsBindAddress: config.metricsAddr,
Scheme: scheme,
Metrics: metricsserver.Options{
BindAddress: config.metricsAddr,
},
HealthProbeBindAddress: config.probeAddr,
LeaderElection: false,
Host: addr,
Port: port,
CertDir: config.certDir,
WebhookServer: webhook.NewServer(webhook.Options{
Host: addr,
Port: port,
CertDir: config.certDir,
}),
})
if err != nil {
setupLog.Error(err, "unable to start manager")
Expand Down
16 changes: 11 additions & 5 deletions hooks/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ import (
"sigs.k8s.io/controller-runtime/pkg/envtest"
logf "sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
"sigs.k8s.io/controller-runtime/pkg/webhook"
"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
)

Expand Down Expand Up @@ -95,11 +97,15 @@ var _ = BeforeSuite(func() {
webhookInstallOptions := &testEnv.WebhookInstallOptions
mgr, err := ctrl.NewManager(k8sConfig, ctrl.Options{
Scheme: scheme,
Host: webhookInstallOptions.LocalServingHost,
Port: webhookInstallOptions.LocalServingPort,
CertDir: webhookInstallOptions.LocalServingCertDir,
LeaderElection: false,
MetricsBindAddress: "0",
WebhookServer: webhook.NewServer(webhook.Options{
Host: webhookInstallOptions.LocalServingHost,
Port: webhookInstallOptions.LocalServingPort,
CertDir: webhookInstallOptions.LocalServingCertDir,
}),
LeaderElection: false,
Metrics: metricsserver.Options{
BindAddress: "0",
},
})
Expect(err).NotTo(HaveOccurred())

Expand Down

0 comments on commit ac1dfbd

Please sign in to comment.