Update for Kubernetes 1.25.9 #33
Conversation
Signed-off-by: zeroalphat <taichi-takemura@cybozu.co.jp>
Makefile
Outdated
| @@ -1,6 +1,6 @@ | |||
| CONTROLLER_TOOLS_VERSION = 0.11.3 | |||
| KUSTOMIZE_VERSION = 4.5.7 | |||
| ENVTEST_K8S_VERSION = 1.25.3 | |||
| ENVTEST_K8S_VERSION = 1.25.8 | |||
There was a problem hiding this comment.
Is this right?
It seems that setup-envtest supports only v1.25.0.
❯ setup-envtest list | grep 1.25
(available) v1.25.0 linux/amd64
There was a problem hiding this comment.
ENVTEST_K8S_VERSION is not used?
There was a problem hiding this comment.
I missed in my review that ENVTEST_K8S_VERSION was no longer used in the following PR.
I am sorry.
I removed the ENVTEST_K8S_VERSION variable.
https://github.com/cybozu-go/pod-security-admission/pull/29/files
There was a problem hiding this comment.
@zeroalphat
If ENVTEST_K8S_VERSION is empty, the latest version (v1.27.1) will be used. Is that OK?
❯ setup-envtest use -p env
export KUBEBUILDER_ASSETS='/home/ikezoe/.local/share/kubebuilder-envtest/k8s/1.27.1-linux-amd64'
There was a problem hiding this comment.
I was commenting without much understanding of how setup-envtest works.
I will change the Makefile to work with the version specified in ENVTEST_K8S_VERSION.
There was a problem hiding this comment.
@zeroalphat
That change is mine. I'm sorry🙏
Signed-off-by: zeroalphat <taichi-takemura@cybozu.co.jp>
This reverts commit d1ac8d1.
No description provided.