-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Kubernetes 1.25.9 #33
Conversation
Signed-off-by: zeroalphat <taichi-takemura@cybozu.co.jp>
Makefile
Outdated
@@ -1,6 +1,6 @@ | |||
CONTROLLER_TOOLS_VERSION = 0.11.3 | |||
KUSTOMIZE_VERSION = 4.5.7 | |||
ENVTEST_K8S_VERSION = 1.25.3 | |||
ENVTEST_K8S_VERSION = 1.25.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this right?
It seems that setup-envtest
supports only v1.25.0.
❯ setup-envtest list | grep 1.25
(available) v1.25.0 linux/amd64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ENVTEST_K8S_VERSION
is not used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed in my review that ENVTEST_K8S_VERSION
was no longer used in the following PR.
I am sorry.
I removed the ENVTEST_K8S_VERSION
variable.
https://github.com/cybozu-go/pod-security-admission/pull/29/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeroalphat
If ENVTEST_K8S_VERSION is empty, the latest version (v1.27.1) will be used. Is that OK?
❯ setup-envtest use -p env
export KUBEBUILDER_ASSETS='/home/ikezoe/.local/share/kubebuilder-envtest/k8s/1.27.1-linux-amd64'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was commenting without much understanding of how setup-envtest works.
I will change the Makefile to work with the version specified in ENVTEST_K8S_VERSION.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeroalphat
That change is mine. I'm sorry🙏
Signed-off-by: zeroalphat <taichi-takemura@cybozu.co.jp>
This reverts commit d1ac8d1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.