Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency aquaproj/aqua to v2.12.0 #73

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

cybozu-neco
Copy link
Collaborator

This PR contains the following updates:

Package Update Change
aquaproj/aqua minor v2.10.1 -> v2.12.0

Release Notes

aquaproj/aqua (aquaproj/aqua)

v2.12.0

Compare Source

Pull Requests | Issues | aquaproj/aqua@v2.11.0...v2.12.0

Features

#​2251 #​2254 Support selecting packages interactively with a fuzzy finder when uninstalling packages

Added -i option to remove command

$ aqua rm -i

If enabling this option, you can select packages interactively with a fuzzy finder.

Others

#​2255 Update aqua-proxy to v1.2.3

v2.11.0

Compare Source

Pull Requests | Issues | aquaproj/aqua@v2.10.1...v2.11.0

Features

#​538 #​2249 Support uninstalling packages
#​2131 #​2065 Support go_build package

Support uninstalling packages

#​538 #​2249

Add a subcommand rm to uninstall packages

Usage
$ aqua rm --all [-a] # Uninstall all packages
$ aqua rm [<registry name>,]<package name> [...] # Uninstall packages
Example
$ aqua rm -a
$ aqua rm cli/cli direnv/direnv
⚠️ Limitation

The following package types can't be removed without --all option.

  • http
  • go_install
Support go_build package

#​2039 #​2131 #​2065

The new package type go_build has been supported.

Example
packages:
  - type: go_build
    repo_owner: suzuki-shunsuke
    repo_name: github-comment
    files:
      - name: github-comment
        src: ./cmd/github-comment
        dir: github-comment-{{trimV .Version}}
$AQUA_ROOT_DIR/pkgs/go_build/github.com/suzuki-shunsuke/github-comment/v4.0.0/
  bin/
    github-comment
  src/github-comment-4.0.0/
    cmd/github-comment/main.go
    ...
Why is the feature needed?

Because some packages couldn't be installed by go install but could be installed by go build.

aqua ever supported go type package, but it was abandoned at aqua v2 because we thought we could replace it to go_install type package.

But we found that some packages couldn't be installed by go install but could be installed by go build.

For example, suzuki-shunsuke/github-comment v5 can't be installed by go install.

$ go install github.com/suzuki-shunsuke/github-comment/v5/cmd/github-comment@v5.2.1
go: github.com/suzuki-shunsuke/github-comment/v5/cmd/github-comment@v5.2.1: github.com/suzuki-shunsuke/github-comment@v5.2.1: invalid version: module contains a go.mod file, so module path must match major version ("github.com/suzuki-shunsuke/github-comment/v5")

$ go install github.com/suzuki-shunsuke/github-comment/cmd/github-comment@v5.2.1 
go: github.com/suzuki-shunsuke/github-comment/cmd/github-comment@v5.2.1: github.com/suzuki-shunsuke/github-comment@v5.2.1: invalid version: module contains a go.mod file, so module path must match major version ("github.com/suzuki-shunsuke/github-comment/v5")

This is because github-comment's go.mod was wrong.

https://github.com/suzuki-shunsuke/github-comment/blob/e5fd429b4d1bd84e8b825a2c7b693d6ac570022f/go.mod#L1

module github.com/suzuki-shunsuke/github-comment

This issue was solved by github-comment v6, but github-comment v2 ~ v5 can't still be installed by go install.

There are many Go tools that can't be installed by go install.

Bug Fixes

#​2120 Fix the default checksum parser to support a tab character as separator
#​2147 Use the basename of the package name as the default command name
#​2176 generate-registry: Fix the format of .tar.zst
#​2202 generate-registry: Remove empty error_message
#​2215 fix a log field version_constraint

Others

#​2151 #​2163 #​2227 Update Go 1.20.6 to 1.21.1


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@zoetrope zoetrope merged commit ecb4635 into main Sep 20, 2023
2 checks passed
@zoetrope zoetrope deleted the renovate/aquaproj-aqua-2.x branch September 20, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants