This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Tweak S3 command and nginx config #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for merging my last PR! I found a couple more things that folks should do when migrating to S3. This adds the proper caching header, as defined in the latest version of Mastodon: mastodon/mastodon#9722 . It also ensures that non-custom emoji are properly served with immutable caching via nginx. It's no fun going back and recursively adding the right cache headers to every object in S3; hopefully this will save some folks that extra step. 😅
|
Thanks for the update! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for merging my last PR! I found a couple more things that folks should do when migrating to S3. This adds the proper caching header, as defined in the latest version of Mastodon: mastodon/mastodon#9722 . It also ensures that non-custom emoji are properly served with immutable caching via nginx.
It's no fun going back and recursively adding the right cache headers to every object in S3; hopefully this will save some folks that extra step. 😅