Fix stackforms var handling and env update. #323
Conversation
| @@ -161,11 +162,13 @@ func NewAPI(opts ...APIOptions) *APIClient { | |||
| } | |||
|
|
|||
| func (a *APIClient) Credentials(org *string) runtime.ClientAuthInfoWriter { | |||
| var token = a.Config.Token | |||
There was a problem hiding this comment.
I don't get the change from
var token = a.Config.Tokento
var token string
token = a.Config.TokenWould have changed to
token := a.Config.Tokeninstead and kept the rest.
There was a problem hiding this comment.
Why I would do this: Because Dave Cheney thinks that's good
The key is that
varacts as a clue that the variable has been deliberately declared as the zero value of the indicated type.When declaring and initialising, consider using the short declaration syntax.
There was a problem hiding this comment.
Good to know.
I will fix that in a future PR
| } | ||
| } | ||
|
|
||
| return runtime.ClientAuthInfoWriterFunc(func(r runtime.ClientRequest, _ strfmt.Registry) error { | ||
| if token == "" { | ||
| if len(token) == 0 { |
There was a problem hiding this comment.
Interest: Why did you chose a function call over a simple comparison?
According to this comment by Russ Cox your interested in the is string question, not in the can I access element at index 0 question, so I think the prior version communicates the idea better.
There was a problem hiding this comment.
Good point. I thought that checking by length was safer.
No description provided.