Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

organizations: provide create/delete endpoint #51

Merged
merged 3 commits into from
Nov 2, 2020
Merged

organizations: provide create/delete endpoint #51

merged 3 commits into from
Nov 2, 2020

Conversation

talset
Copy link
Member

@talset talset commented Oct 27, 2020 •
edited
Loading

implement cy org create/delete

tormath1
tormath1 reviewed Oct 29, 2020
View reviewed changes
cmd/cycloid/organizations/delete.go Outdated Show resolved Hide resolved
cmd/cycloid/organizations/delete.go Outdated Show resolved Hide resolved
cmd/cycloid/organizations/delete.go Outdated Show resolved Hide resolved
@tormath1
Copy link
Contributor

tormath1 commented Nov 2, 2020

@talset CI is failing :)

@talset talset force-pushed the fl-orgdel branch 2 times, most recently from 60fb017 to 8ab491a Compare November 2, 2020 13:22
@talset talset changed the title organizations: provide delete endpoint organizations: provide create/delete endpoint Nov 2, 2020
@talset talset requested a review from tormath1 November 2, 2020 13:28
tormath1
tormath1 reviewed Nov 2, 2020
View reviewed changes
Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny comments. LGTM :)

Don't forget to add the CHANGELOG entry :)

cmd/cycloid/middleware/organization.go Outdated Show resolved Hide resolved
cmd/cycloid/middleware/organization.go Outdated Show resolved Hide resolved
@tormath1
Copy link
Contributor

tormath1 commented Nov 2, 2020

LGTM, just to need to rebase with develop (one simple conflict to expect on the changelog)

@talset talset merged commit 56e7faf into develop Nov 2, 2020
@talset talset deleted the fl-orgdel branch November 2, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tormath1 tormath1 tormath1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talset @tormath1