Azure support #40
Merged
Azure support #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xescugc
requested changes
Aug 10, 2020
| @@ -0,0 +1,673 @@ | |||
| { | |||
| "version": 4, | |||
generate/testdata/azure.tfstate
Outdated
| @@ -5,6 +5,7 @@ | |||
| "lineage": "65f8a469-c021-ee9d-a634-45cdf74dff6b", | |||
| "outputs": { | |||
| "tls_private_key": { | |||
| "value": "-----", | |||
provider/azurerm/azurerm.go
Outdated
|
|
||
| var ( | ||
| usedAttributes = []string{ | ||
| "azurerm_virtual_network_peering", |
There was a problem hiding this comment.
I think not, this should be attributes not resources, so basically it is virtual_network_name remote_virtual_network_id, id and name for what I see.
|
Done. I'm sorry about rebase, but I've done something wrong and had to. |
kerak19
pushed a commit
that referenced
this pull request
Aug 10, 2020
|
Added |
xescugc
requested changes
Aug 10, 2020
CHANGELOG.md
Outdated
Comment on lines
7
to
8
| - Azure support | ||
| ([PR #40](https://github.com/cycloidio/inframap/pull/40)) |
There was a problem hiding this comment.
Ok, modified the PR link to issue link
kerak19
pushed a commit
that referenced
this pull request
Aug 10, 2020
|
Done. Will have to modify the commit message during rebase |
kerak19
pushed a commit
that referenced
this pull request
Aug 10, 2020
|
Done |
xescugc
requested changes
Aug 10, 2020
Comment on lines
+52
to
+68
| func (a Provider) ResourceInOut(id, rs string, cfgs map[string]map[string]interface{}) ([]string, []string) { | ||
| var ins, outs []string | ||
| cfg := cfgs[id] | ||
| switch rs { | ||
| case "azurerm_virtual_network_peering": | ||
| vnn := cfg["virtual_network_name"] | ||
| vnID, ok := getRsIDByName(cfgs, vnn) | ||
| if !ok { | ||
| break | ||
| } | ||
| ins = append(ins, vnID) | ||
|
|
||
| rvni := cfg["remote_virtual_network_id"] | ||
| outs = append(outs, rvni.(string)) | ||
| } | ||
| return ins, outs | ||
| } |
There was a problem hiding this comment.
We have test for ths on the other providers
|
Done |
added 6 commits
August 10, 2020 17:29
|
Done |
xescugc
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Azure:
tfstatetfCloses #8