Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows New Line Control Character Issue #1

Open
cyclone-github opened this issue Nov 30, 2024 · 0 comments
Open

Windows New Line Control Character Issue #1

cyclone-github opened this issue Nov 30, 2024 · 0 comments
Assignees
@cyclone-github
Labels
bug Something isn't working

Comments

@cyclone-github
Copy link
Owner

The current logic for detecting newline control characters does not work properly when processing wordlists created on Windows with \r\n line endings. This causes false negatives in the cracking process.

metamask_pwn/metamask_decryptor/metamask_decryptor.go

Line 439 in 02c57e7

word := strings.TrimRight(scanner.Text(), "\n")

This is the same bug found in phantom_decryptor here:
cyclone-github/phantom_pwn#6
@cyclone-github cyclone-github added the bug Something isn't working label Nov 30, 2024
@cyclone-github cyclone-github self-assigned this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cyclone-github cyclone-github

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cyclone-github