Use static variable instead of class constant for USER_ROLES for 5.5.…

…9 compat, fix #264
cydrobolt · Dec 9, 2016 · c95c964 · c95c964
1 parent 44bb4ef
commit c95c964
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 7 deletions.
diff --git a/app/Factories/UserFactory.php b/app/Factories/UserFactory.php
@@ -7,7 +7,11 @@
 use App\Helpers\UserHelper;
 
 class UserFactory {
-    public static function createUser($username, $email, $password, $active=0, $ip='127.0.0.1', $api_key=false, $api_active=0, $role=UserHelper::USER_ROLES['default']) {
+    public static function createUser($username, $email, $password, $active=0, $ip='127.0.0.1', $api_key=false, $api_active=0, $role=false) {
+        if (!$role) {
+            $role = UserHelper::$USER_ROLES['default'];
+        }
+
         $hashed_password = Hash::make($password);
         $recovery_key = CryptoHelper::generateRandomHex(50);
 

diff --git a/app/Helpers/UserHelper.php b/app/Helpers/UserHelper.php
@@ -6,7 +6,7 @@
 use Hash;
 
 class UserHelper {
-    const USER_ROLES = [
+    public static $USER_ROLES = [
         'admin'    => 'admin',
         'default'  => '',
     ];

diff --git a/app/Http/Controllers/AdminController.php b/app/Http/Controllers/AdminController.php
@@ -31,8 +31,8 @@ public function displayAdminPage(Request $request) {
 
         return view('admin', [
             'role' => $role,
-            'admin_role' => UserHelper::USER_ROLES['admin'],
-            'user_roles' => UserHelper::USER_ROLES,
+            'admin_role' => UserHelper::$USER_ROLES['admin'],
+            'user_roles' => UserHelper::$USER_ROLES,
             'api_key' => $user->api_key,
             'api_active' => $user->api_active,
             'api_quota' => $user->api_quota,

diff --git a/app/Http/Controllers/AdminPaginationController.php b/app/Http/Controllers/AdminPaginationController.php
@@ -59,7 +59,7 @@ class="form-control"';
                 }
                 $select_role .= '>';
 
-                foreach (UserHelper::USER_ROLES as $role_text => $role_val) {
+                foreach (UserHelper::$USER_ROLES as $role_text => $role_val) {
                     // Iterate over each available role and output option
                     $select_role .= '<option value="' . e($role_val) . '"';
 

diff --git a/app/Http/Controllers/SetupController.php b/app/Http/Controllers/SetupController.php
@@ -98,7 +98,7 @@ public static function performSetup(Request $request) {
         $acct_username = $request->input('acct:username');
         $acct_email = $request->input('acct:email');
         $acct_password = $request->input('acct:password');
-        $acct_group = UserHelper::USER_ROLES['admin'];
+        $acct_group = UserHelper::$USER_ROLES['admin'];
 
         // if true, only logged in users can shorten
         $st_shorten_permission = $request->input('setting:shorten_permission');
@@ -215,7 +215,7 @@ public static function finishSetup(Request $request) {
             return redirect(route('setup'))->with('error', 'Could not create database. Perhaps some credentials were incorrect?');
         }
 
-        $user = UserFactory::createUser($setup_finish_args->acct_username, $setup_finish_args->acct_email, $setup_finish_args->acct_password, 1, $request->ip(), false, 0, UserHelper::USER_ROLES['admin']);
+        $user = UserFactory::createUser($setup_finish_args->acct_username, $setup_finish_args->acct_email, $setup_finish_args->acct_password, 1, $request->ip(), false, 0, UserHelper::$USER_ROLES['admin']);
 
         return view('setup_thanks')->with('success', 'Set up completed! Thanks for using Polr!');
     }