fix: don't overwrite primaryKey with LAST_INSERT_ID() if exists #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimmyDaddy
approved these changes
Aug 31, 2023
fengmk2
reviewed
Aug 31, 2023
| @@ -806,7 +806,8 @@ class Bone { | |||
|
|
|||
| const spell = new Spell(Model, opts).$insert(data); | |||
| return spell.later(result => { | |||
| this[primaryKey] = result.insertId; | |||
| // LAST_INSERT_ID() breaks on TDDL, and on OceanBase if primary key is not integer | |||
| if (this[primaryKey] == null) this[primaryKey] = result.insertId; | |||
There was a problem hiding this comment.
要 oceanbase 用非整型字段当主键才可以复现，比较难复刻……
There was a problem hiding this comment.
厉害👍
这个是数据库自动做了取整然后通过 L809 订正了 user.id？
There was a problem hiding this comment.
MySQL 本地测试，数据库存的肯定不是这个浮点数 ID，否则不会报错（后面查用户权限的时候失败）
There was a problem hiding this comment.
理论上 user_id 如果声明了类型，也可以在应用层取整缓解这个问题
主要这个 edge case 和之前 ob 那个是冲突的，ob 那个是主键自定义之后返回了一个其他的唯一 id（可能是内部 id），只能两者里面选一个……
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
att