Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: turn on compilerOptions.strict #403

Merged
merged 1 commit into from
Nov 1, 2023
Merged

refactor: turn on compilerOptions.strict #403

merged 1 commit into from
Nov 1, 2023

Conversation

cyjake
Copy link
Owner

@cyjake cyjake commented Oct 31, 2023

att

@cyjake cyjake force-pushed the strict-tsc branch 2 times, most recently from bba6cf6 to 084954c Compare October 31, 2023 17:05
@cyjake cyjake changed the title [wip] refactor: turn on compilerOptions.strict refactor: turn on compilerOptions.strict Nov 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c5bdd50) 0.00% compared to head (6d45019) 63.14%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #403       +/-   ##
===========================================
+ Coverage        0   63.14%   +63.14%     
===========================================
  Files           0       42       +42     
  Lines           0     4249     +4249     
  Branches        0       62       +62     
===========================================
+ Hits            0     2683     +2683     
- Misses          0     1550     +1550     
- Partials        0       16       +16     
Files Coverage Δ
src/adapters/sequelize.js 93.20% <100.00%> (ø)
src/drivers/index.js 81.25% <100.00%> (ø)
src/drivers/sqljs/index.ts 100.00% <ø> (ø)
src/realm/base.js 96.42% <100.00%> (ø)
src/data_types.ts 88.23% <83.33%> (ø)
src/drivers/sqljs/sqljs-connection.ts 55.93% <33.33%> (ø)

... and 36 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmyDaddy JimmyDaddy merged commit 0d34906 into master Nov 1, 2023
4 checks passed
@JimmyDaddy JimmyDaddy deleted the strict-tsc branch November 1, 2023 08:47
@cyjake
Copy link
Owner Author

cyjake commented Nov 1, 2023

v2.11.5-beta.0

"files": [
"dist",
"src",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: Cannot find module 'leoric/src/setup_hooks'
Require stack:
- /Users/fengmk2/git/github.com/cnpm/cnpmcore/node_modules/_@eggjs_tegg-orm-plugin@3.25.0@@eggjs/tegg-orm-plugin/lib/LeoricRegister.js
- /Users/fengmk2/git/github.com/cnpm/cnpmcore/node_modules/_@eggjs_tegg-orm-plugin@3.25.0@@eggjs/tegg-orm-plugin/lib/SingletonORM.js
- /Users/fengmk2/git/github.com/cnpm/cnpmcore/app/repository/PackageRepository.ts

breaking 了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants