chore: improve test coverage after migrating ts project #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyjake
commented
Nov 7, 2023
| @@ -5,7 +5,7 @@ const path = require('path'); | |||
| const sinon = require('sinon'); | |||
| const SqlString = require('sqlstring'); | |||
|
|
|||
| const { connect, raw, Bone, disconnect, Raw, SqliteDriver } = require('../..'); | |||
| const { connect, raw, Bone, disconnect, Raw, SqliteDriver } = require('../../src'); | |||
There was a problem hiding this comment.
没搞懂怎么让 nyc 支持 lib + source map 这种形式的覆盖率统计，改成测试代码全部使用 ts-node 运行，感觉也还可以
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #406 +/- ##
===========================================
+ Coverage 63.14% 96.66% +33.51%
===========================================
Files 42 45 +3
Lines 4249 3625 -624
Branches 62 71 +9
===========================================
+ Hits 2683 3504 +821
+ Misses 1550 106 -1444
+ Partials 16 15 -1 ☔ View full report in Codecov by Sentry. |
SmartOrange
reviewed
Nov 7, 2023
cyjake
force-pushed
the
improve-test-coverage
branch
from
599e7b4
to
921ce49
Compare
cyjake
force-pushed
the
improve-test-coverage
branch
from
921ce49
to
d0c06ce
Compare
JimmyDaddy
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
att