Export public interface #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exports the types involved in the public interface to remain compatible with existing users. The object extension of the SSHConfig class is converted to static methods to allow SSHConfig to be used as a type. Separator is exported because it is the type of Directive::separator, but Space is only used internally so not exported. Signed-off-by: Benjamin Gray <bgray@linux.ibm.com>
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 96.96% 96.98% +0.02%
==========================================
Files 3 3
Lines 297 299 +2
Branches 81 81
==========================================
+ Hits 288 290 +2
Misses 4 4
Partials 5 5
☔ View full report in Codecov by Sentry. |
cyjake
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exports the types involved in the public interface to remain compatible with existing users.
The object extension of the
SSHConfigclass is converted to static methods to allowSSHConfigto be used as a type.Separatoris exported because it is the type ofDirective::separator, butSpaceis only used internally so not exported.Fixes #69
There are still remaining errors, but they are due to that package not handling the
string | string[]value type correctly, so nothing really to do here.