Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform dependencies section in suite.rc #22

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Uniform dependencies section in suite.rc #22

merged 1 commit into from
Aug 1, 2019

Conversation

matthewrmshin
Copy link
Contributor

Companion for cylc/cylc-flow#3191 - cycling and non-cycling suites now have
uniform level in the dependencies section.

@matthewrmshin matthewrmshin self-assigned this Jun 17, 2019
@matthewrmshin matthewrmshin marked this pull request as ready for review June 17, 2019 10:45
@hjoliver
Copy link
Member

(Will review this after/with cylc/cylc-flow/pull/2935)

@matthewrmshin
Copy link
Contributor Author

Re-based.

Companion for cylc/cylc-flow#3191 - cycling and non-cycling suites now have
uniform level in the dependencies section.
@hjoliver hjoliver self-requested a review July 29, 2019 04:48
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@oliver-sanders
Copy link
Member

The Cylc Tutorial is in this repo now as well. Do we want to attempt that after #40 or now?

@hjoliver
Copy link
Member

I guess that's mainly a question for @matthewrmshin. (The order doesn't really matter, except that it affects who does the work).

@matthewrmshin
Copy link
Contributor Author

matthewrmshin commented Aug 1, 2019

Merge both in if possible. Open follow-on issue.

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's get this show on the road. This one is documentation only, and is just s/old/new/g, so one review will do.

@hjoliver hjoliver merged commit b37e7f7 into cylc:master Aug 1, 2019
@matthewrmshin matthewrmshin deleted the uniform-dependencies-section branch August 7, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants