-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authorization documentation #300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a bunch of minor suggestions and questions.
ca725b1
to
e35c42e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some minor comments.
CI is failing, perhaps try rebasing/pushing to trigger a build with up to date cylc-flow/cylc-uiserver.
src/user-guide/sharing-access-to-workflows/sharing-access-to-workflows.rst
Outdated
Show resolved
Hide resolved
src/user-guide/sharing-access-to-workflows/sharing-access-to-workflows.rst
Outdated
Show resolved
Hide resolved
src/user-guide/sharing-access-to-workflows/sharing-access-to-workflows.rst
Outdated
Show resolved
Hide resolved
Such behaviours cannot be controlled through technical measures so must be | ||
enforced by site policy. By the same token, however, because Cylc UI Servers | ||
(and Schedulers) run as the user, one user cannot compromise another user's | ||
account using Cylc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
account using Cylc. | |
UI Server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sentence was suggested by me. I'm not sure I worded it very well, or that your suggestion here is correct either. Technically, granting another user access to my workflows could (or does) compromise my UIS and my account, but that's by design. What I meant to suggest was that granting another user access to my account cannot compromise any other users' account (because everything I granted access to runs as me).
src/user-guide/sharing-access-to-workflows/sharing-access-to-workflows.rst
Outdated
Show resolved
Hide resolved
0c25d35
to
690e138
Compare
update 7-8 Add link to authorisation from architecture remove ping from READ
3d8b31e
to
6051775
Compare
Rebased. There is still an unresolved comment relating to this sentence... |
Thanks @datamel I'll get this merged. Will reconsider the hard-to-word sentence as a follow-up. |
Accompanies cylc/cylc-uiserver#204.
Partially addresses Document Configurable Authorization #271.
Documents authorization and adds a new section,
Sharing Workflows
to the user-guide.