Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: hide _cylc-install directory #4170

Closed
oliver-sanders opened this issue Apr 12, 2021 · 1 comment · Fixed by #4236
Closed

review: hide _cylc-install directory #4170

oliver-sanders opened this issue Apr 12, 2021 · 1 comment · Fixed by #4236
Assignees
@wxtim
Labels
small
Milestone
cylc-7.8.9 and 7.9.4

Comments

@oliver-sanders
Copy link
Member

Cylc Review is following the source symlink back to the source directory for workflows installed via cylc install.

In the event that the source directory is a Cylc7 suite (so contains a suite.rc file) this causes it to be displayed.

Suggest checking for the existance of the log directory as a generic fic. Cylc7/8 installed/running suite/flows should all have a log dir.

Pull requests welcome!
@oliver-sanders oliver-sanders added this to the cylc-7.8.x milestone Apr 12, 2021
@wxtim wxtim mentioned this issue May 31, 2021
Merged
5 tasks
@wxtim wxtim linked a pull request May 31, 2021 that will close this issue
Cylc review fixes.skip links to source #4236
Merged
5 tasks
@oliver-sanders
Copy link
Member Author

closed by #4236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wxtim wxtim

Labels
small
Projects
None yet
Milestone
cylc-7.8.9 and 7.9.4
Development

Successfully merging a pull request may close this issue.

Cylc review fixes.skip links to source wxtim/cylc
3 participants
@hjoliver @oliver-sanders @wxtim