-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cylc review fixes.skip links to source #4236
Cylc review fixes.skip links to source #4236
Conversation
Bumped to 7.8.x (otherwise it will show up as closed against the wrong codebase). |
Travis tests still working 👍. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested as working.
In the process I noticed that a running Cylc 8 workflow was marked at "stopped", not sure if that's been spotted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked out this branch and read the code. Tested as working. One minor typo spotted that pre-dates this pr. Not important enough to withhold merge though.
Co-authored-by: Melanie Hall <37735232+datamel@users.noreply.github.com>
(dependent on #4233 )
These changes close #4170 and a minor issue without a ticket.
_cylc-install
directory #4170 Prevent Cylc Review from following links back to source directory for workflows installed using Cylc Install.runN
symlink to the latest run folder.[marked against a Cylc 8 milestone because this change only adds support for Cylc 8 workflows, and should not change an aspect of Cylc 7 functioning]
CONTRIBUTING.md
and added my name as a Code Contributor.To test
Install a workflow with Cylc 8.
Switch to Cylc 7 and start Cylc Review (
cylc review start
).Ensure that you cannot see links to
~/cylc-run/<workflow>/_cylc-install
or_cylc_install
.Ensure that you cannot see links to
~/cylc-run/<workflow>/runN