Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import issues in cylc get-directory #3084

Merged
merged 1 commit into from
Apr 7, 2019
Merged

Fix import issues in cylc get-directory #3084

merged 1 commit into from
Apr 7, 2019

Conversation

kinow
Copy link
Member

@kinow kinow commented Apr 6, 2019

Never used this command (also not sure if will be kept in Cylc 8, e.g. #2972), and it works in my local environment. But I suspect if remrun returns true, it will probably raise ImportError or ModuleNotFoundError, as the import sys is after the call to sys.exit.

@kinow kinow self-assigned this Apr 6, 2019
@kinow kinow added the small label Apr 6, 2019
@kinow kinow added this to the cylc-8.0a1 milestone Apr 6, 2019
hjoliver
hjoliver approved these changes Apr 7, 2019
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 one review will do for this

@hjoliver
Copy link
Member

hjoliver commented Apr 7, 2019

(Back-port to 7.8.x not needed ... the problem doesn't exist there)

@hjoliver hjoliver merged commit 8bc7aa0 into cylc:master Apr 7, 2019
@kinow kinow mentioned this pull request May 15, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

Assignees

@kinow kinow

Labels
small
Projects
None yet
Milestone
cylc-8.0a1
Development

Successfully merging this pull request may close these issues.
2 participants
@kinow @hjoliver