job platforms: Global Spec Changes #3453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and task>remote will need to take place
Mels platform branch broken test fix
Add, commented for now, the upgrader to move settings from [runtime][TASK][job] to [runtime][TASK]
Platform support
dpmatthews
reviewed
Dec 4, 2019
dpmatthews
reviewed
Dec 4, 2019
dpmatthews
reviewed
Dec 4, 2019
dpmatthews
reviewed
Dec 4, 2019
dpmatthews
reviewed
Dec 4, 2019
dpmatthews
reviewed
Dec 4, 2019
dpmatthews
approved these changes
Dec 4, 2019
hjoliver
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Agree with @oliver-sanders' suggestions, otherwise approved 👍
…st type correct to string list
platform alias --> platform groups; platform groups a dict; remote ho…
|
@oliver-sanders please can you sanity check and merge? |
oliver-sanders
requested changes
Dec 11, 2019
cylc/flow/cfgspec/globalcfg.py
Outdated
| '__MANY__': [VDR.V_STRING_LIST] | ||
| # Platform Groups | ||
| 'platform groups': { | ||
| '__MANY__': {} |
There was a problem hiding this comment.
Needs the platforms setting e.g:
'platform groups': {
'__MANY__': {
'platforms': [VDR.V_STRING_LIST]
}
}
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add job platforms section to cylc/flow/cfgspec/global_config.rc.
Included the content currently included in the [hosts][many] section.
Did not include the [hosts][localhost]
Added platform setting to the task section of cylc/flow/cfgspec/suite.rc.
Moved Configs from suite.rc[runtime][TASK][job/remote] to flow.rc[platforms][MANY].
The diff for PR #3348 should provide further details.
Remove old configurations <----- Not completed yet as do not want to break master. Comments added to remind us to delete these in future.
Appropriate tests are included (unit and/or functional).
No documentation update required yet.