-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentication Washup & Fixed Cylc Scan #3509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, what a simplification.
You know you are heading in the right direction when you can strip out 1600 lines of code and it still works.
I've found one thing which I think may break remote functionality but it's an easy fix.
451f3d6
to
3047122
Compare
Note that this change (with the removal of the contact 2 file) will break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is all looking good, will test tomorrow.
9f67aa9
to
69deb64
Compare
69deb64
to
11d9a5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and tested as working 👍 One trivial suggestion.
@@ -339,107 +329,6 @@ def get_contact_file(reg): | |||
get_suite_srv_dir(reg), SuiteFiles.Service.CONTACT) | |||
|
|||
|
|||
def get_auth_item(item, reg, owner=None, host=None, content=False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goodbye and good riddance!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor comments otherwise looks good.
a32cf6e
to
200161b
Compare
902ea78
to
1c065e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me & I've tested that cylc scan now skips cylc 7 suites
Two approvals and an "otherwise looks good" from @oliver-sanders, with the caveat addressed. Merging... |
Close #3449
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.Notes to reviewers:
Closes #3516