tui: mutations

[oliver-sanders]

These changes partially address #3529

• Implement basic hard-coded mutations in Cylc Tui.
• Obtain cycle points using cyclePoints: familyProxies(ids: ["root"]) trick.
• Bonus testing.

This should open up the path to getting Cylc out for alpha testing.

Requirements check-list

• I have read CONTRIBUTING.md and added my name as a Code Contributor.
• Contains logically grouped changes (else tidy your branch by rebase).
• Does not contain off-topic changes (use other PRs for other changes).
• Appropriate tests are included (unit and/or functional).
• No change log entry required (there is already a changelog for Tui).
• No documentation update required.

[kinow]

Really nice. Minor comments, no blockers.

@oliver-sanders I accidentally hit Enter twice and held my workflow. Would a default empty state (e.g. "Select one of the options below" or similar) be useful to prevent users accidentally triggering mutations?

Also, I decided to try clicking Enter a lot of times - more than 10, less than 20 times. And managed to lock the cylc tui screen again, having to kill it. That's the same issue we had before, so not a blocker for this, just in case that's important.

Another thing too, is that if you stop the suite, and then click enter on cylc tui screen you get several Action panels.

Approved 🎉

[kinow]

These functions look useful (I feel like I had to write something similar in Cylc UI). Maybe later this will be promoted out of the tui module and be used by other code in Cylc Flow (or even Cylc UI Server which imports Cylc Flow).

[oliver-sanders]

Yes, there is crossover between the two UIs, sadly working with different languages it's difficult to port one to the other.

TUI should always be simple and lightweight, I'd expect the WUI to vastly outstrip it in complexity.

[kinow]

(Some functional test appears to be failing, but this change doesn't seem to change anything in the code of Cylc Flow, only in the tui package, so ignoring that... also cannot kick Travis, 🤷‍♂️ )

[oliver-sanders]

Added a default "cancel" button to the actions overlay to avoid accidental mutation.

I couldn't replicate the multiple action boxes or freeze bugs. Let me know if they occur again.

[wxtim]

def review():
  if you_wanted_thorough_code_review:
      request_detailed_explanation()
      return False
  else:
      return {
        'Functionally tested': True,
        'Bruno\'s comments addressed': True
      }

It worked with my deliberately horrible (800 tasks per cycle) workflow.

[dwsutherland]

Works well for me! Nice work ✔️