-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralise general id delimiter #3625
Conversation
The bug was the conditions using a false ID for their taskProxy, so now works:
|
t_id = f"{workflow_id}/{point}/{name}" | ||
t_id = f"{workflow_id}{ID_DELIM}{point}{ID_DELIM}{name}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't matter that this was a different delimiter here? (/
vs |
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Or was that the bug? it's used in PbConditions
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this was the bug that needed fixed. But can't import from cylc.flow.data_store_mgr
.
This PR:
Sibling PR: cylc/cylc-uiserver#140
(needs to be merge after this one)
The centralisation/put-at-lower-level is needed due to:
data_store_mgr
, butprerequisites
is imported todata_store_mgr
indirectly)Justification for
cylc/flow/__init__.py
location:cylc/flow/task_id.py
), used for workflow/jobs/families ...etc.ID_DELIM
). See Universal suite/task/cycle delimiter (universal identifier) #3592Could be it's own module.. But, as a one-liner and used by UIS,
cylc.flow
seems appropriate.Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.