Intel host select.get platform group #3868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_platform -> get_platform_group platform_from_name -> platforms_from_name
wxtim
requested review from
oliver-sanders and
datamel
and removed request for
oliver-sanders
wxtim
added
could be better
wxtim
force-pushed
the
intel-host-select.get_platform_group
branch
from
2e3d0e1
to
fa8d7a5
Compare
|
Closed in favour of cracking on with IHS having reached this milestone point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are a pre-requisite to addressing #3827
To carry out intelligent host selection the code needs to have access not to platforms but to platform groups.
To this end this PR
platforms.get_platformwithplatforms.get_platform_groupandplatforms.get_platform_from_nametoget_platforms_from_name, so that code calling it has information about the whole group of platforms. If regex only matches a single platform rather than a platform group then a dummy platform group dictionary containing that single platform is returned. Question: Should this have selection method set to "first" to save time?platforms.get_localhost_platform- in many places in the codeget_platform()is called. This function replaces that one, and makes it easier to differentiate cases where we just want info about the localhost platform with cases where something more complex is happening.platforms.get_host_from_platform_group. As withplatforms.get_host_from_platformthis is a placeholder for more sophisticated logic. At the moment it simply picks a random platform from the platform_group and callsget_host_from_platform.