Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conf: remove explicit group meta entry #3905

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Oct 30, 2020

Closes #2776

(effectively a documentation change)

Remove the "explicit" group configuration since it is not actually supported anywhere in Cylc at present. The config is still valid as it's just metadata.

Rather than brining back explicit support for the group setting in the new UI we would allow any arbitrary metadata item to be used (e.g. title, description, etc). See also cylc/cylc-ui#337.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (why?).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.
  • No dependency changes.

@oliver-sanders oliver-sanders added the doc Documentation label Oct 30, 2020
@oliver-sanders oliver-sanders added this to the cylc-8.0a3 milestone Oct 30, 2020
@oliver-sanders oliver-sanders self-assigned this Oct 30, 2020
@MetRonnie
Copy link
Member

Closes 2276

I'm not sure that's the right one, #2276 is a PR

@oliver-sanders
Copy link
Member Author

Sorry 2776.

@MetRonnie
Copy link
Member

Just looks like a functional test needs updating

@MetRonnie MetRonnie merged commit 0fd717f into cylc:master Nov 2, 2020
@hjoliver hjoliver modified the milestones: cylc-8.0a3, cylc-8.0b0 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate the group setting
3 participants