Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: prepare for ssh task comms #4111

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Conversation

oliver-sanders
Copy link
Member

  • use extglobs for platform pattern matching comms:?(tcp|ssh)
  • upgrade cylc message tests to run on remote platforms (as well as
    local ones)
  • set cylc message tests to run for ssh task comms (as well as tcp)
  • set fileinstall tests to run for ssh (as well as tcp)
  • improve test battery documentation

This should make testing #3327 easier, deals with some of the less well documented aspects of the functional testing framework.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate tests are included (unit and/or functional).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.
  • No dependency changes.

@oliver-sanders oliver-sanders added the doc Documentation label Mar 5, 2021
@oliver-sanders oliver-sanders added this to the cylc-8.0b0 milestone Mar 5, 2021
@oliver-sanders oliver-sanders self-assigned this Mar 5, 2021
tests/functional/README.md Outdated Show resolved Hide resolved
tests/functional/README.md Outdated Show resolved Hide resolved
etc/conf/ssh_config Show resolved Hide resolved
* use extglobs for platform pattern matching comms:?(tcp|ssh)
* upgrade cylc message tests to run on remote platforms (as well as
  local ones)
* set cylc message tests to run for ssh task comms (as well as tcp)
* set fileinstall tests to run for ssh (as well as tcp)
* improve test battery documentation
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures unrelated, changes look good to me. Thanks Oliver!

@oliver-sanders
Copy link
Member Author

Test failures look like they are due to cylc-rose, will wait until they are fixed and the test pass before merge.

* cylc-rose bug causing cylc-rose tests to fail
* will re-enable once fixed
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing now 👍

@hjoliver hjoliver merged commit 2ec8cbb into cylc:master Mar 11, 2021
@oliver-sanders oliver-sanders deleted the tb-ssh-comms branch March 11, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants