-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: prepare for ssh task comms #4111
Conversation
* use extglobs for platform pattern matching comms:?(tcp|ssh) * upgrade cylc message tests to run on remote platforms (as well as local ones) * set cylc message tests to run for ssh task comms (as well as tcp) * set fileinstall tests to run for ssh (as well as tcp) * improve test battery documentation
2f43a01
to
50234b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failures unrelated, changes look good to me. Thanks Oliver!
Test failures look like they are due to cylc-rose, will wait until they are fixed and the test pass before merge. |
* cylc-rose bug causing cylc-rose tests to fail * will re-enable once fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests passing now 👍
local ones)
This should make testing #3327 easier, deals with some of the less well documented aspects of the functional testing framework.
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.