Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Cylc Review to access Cylc 8 Workflow data. #4134

Merged
merged 10 commits into from
Mar 23, 2021

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Mar 18, 2021

These changes partially address #4113 - Depending upon discussion on that issue, this may be a complete solution.

  • Fix access to task jobs list. At this stage I have an informally tested fix. I've put it up for review so that reviewers can try it.
  • Allow access to cylc.flow file. Modified the list of files so that this can be a 1-stop-shop.
  • Existing tests for cylc-review don't break differently to target branch. 😢
  • Create a formal test that Cylc8 Workflows can be read. Manual testing only because this a complex test for legacy software.
  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate change log entry included.
  • No dependency changes.

@wxtim wxtim added the small label Mar 18, 2021
@wxtim wxtim added this to the cylc-7.8.x milestone Mar 18, 2021
@wxtim wxtim self-assigned this Mar 18, 2021
@MetRonnie MetRonnie self-requested a review March 18, 2021 17:25
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming it has at least been tested manually

@wxtim
Copy link
Member Author

wxtim commented Mar 19, 2021

I'm not convinced that it's going to be particularly straightforward to automate a test for this. I think to test it manually that you should:

  • Run at least 1 (but not necessarily the same) suite in Cylc7 and Cylc8.
  • With cylc review open and browse around.
  • Confirm that links and pages work.

@wxtim
Copy link
Member Author

wxtim commented Mar 19, 2021

@dpmatthews said it worked for him on a quick test.

Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have played a cylc 8 workflow and tested cylc review both fails on master and works as expected on this branch.
Thanks for getting me up and running with this @wxtim.
I have sent you a quick pm with the extra files from the cylc-install work.

Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just need to test...

@oliver-sanders
Copy link
Member

Tested, everything working as expected.

@oliver-sanders oliver-sanders merged commit 2983bb5 into cylc:7.8.x Mar 23, 2021
@wxtim wxtim deleted the 7.8.x.cylc7-review-cylc8-workflows branch March 24, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants