Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pause: workflow cannot be stalled if it is paused #4244

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Jun 4, 2021

closes #4243

Fixes bug where the stall detection could release runahead tasks.

Spotted by @MetRonnie on #4237 (comment)

Bug was intermittent, however, could be made dependable by jamming an await asyncio.sleep(1) into tests/i/test_scan::test_scan_sigstop.

The released can be seen an extra log message in the test output which was causing the failure:

E             Full diff:
E               [
E             +  (20,
E             +   '[one.1] -released from runahead'),
E                (30,...

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.py and
    conda-environment.yml.
  • Appropriate tests are included (unit and/or functional).
  • No change log entry required (why? bug never released)
  • (master branch) I have opened a documentation PR at cylc/cylc-doc/pull/XXXX.
  • (7.8.x branch) I have updated the documentation in this PR branch.
  • No documentation update required.

* fixes bug where the stall detection could release runahead tasks
@oliver-sanders oliver-sanders added the bug Something is wrong :( label Jun 4, 2021
@oliver-sanders oliver-sanders added this to the cylc-8.0b2 milestone Jun 4, 2021
@oliver-sanders oliver-sanders self-assigned this Jun 4, 2021
@oliver-sanders
Copy link
Member Author

I don't fancy adding a dedicated integration test for this as that would involve putting a workflow into a stalled state then waiting around for an arbitrary period just to make sure it doesn't do anything.

@dwsutherland dwsutherland merged commit d85dc16 into cylc:master Jun 9, 2021
@oliver-sanders oliver-sanders deleted the stalled-runahead branch June 9, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MacOS flaky integration test
3 participants