Intelligent Host Selection from Platform Group #4329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added selection method to config for platform groups functional tests for platform from group
wxtim
changed the title
hjoliver
reviewed
Aug 3, 2021
|
(Resolved a small conflict on this branch via GH UI) |
hjoliver
reviewed
Aug 31, 2021
hjoliver
reviewed
Aug 31, 2021
|
Could get coverage up a bit? |
Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
Always happy to try to do this. But there may have been reasons why I haven't. |
wxtim
commented
Sep 1, 2021
…ihs.from-platform-group * 'ihs.from-platform-group' of github.com:wxtim/cylc: (75 commits) Update cylc/flow/task_job_mgr.py Update cylc/flow/exceptions.py Add unit test. update cfgspec doc Cycle point format colon restriction Codecov: use flags for fast & functional tests Remove :cylc:conf: Attempt to infer run number if there is no runN symlink. (cylc#4373) Update cylc/flow/cfgspec/globalcfg.py Update cylc/flow/cfgspec/globalcfg.py Added ..attention:: to localhost == scheduler host NOT ROSE_ORIG_HOST Add `versionchanged` admonitions to certain config items Add selection to global.cylc[platforms][localhost] Prevents documentation build failure. GH Actions: Update action Fix test codecov: fiddle configuration Update changelog Change 'ignore' to 'reload' for cycle point cli opts Tidy Run the container after pulling the image from GHCR ...
…ihs.from-platform-group * 'ihs.from-platform-group' of github.com:wxtim/cylc: GH Actions: Add test workflows badges to release PRs Hot fix line length. response to review. Apply suggestions from code review Apply suggestions from code review Update cylc/flow/cfgspec/globalcfg.py Added deprecation warnings in platforms section platform documentation changes cli: change list_plugins to return a string cli: remove gui from command blacklist schema: correct faulty enum
wxtim
commented
Sep 1, 2021
And now it says patch is 100%. I'm confused. |
|
Note that Codecov starts reporting coverage as soon as it receives the first uploaded report, so it will initially have the (low) fast-tests coverage only until the functional tests finish |
wxtim
force-pushed
the
ihs.from-platform-group
branch
from
06d2672
to
e4494a4
Compare
hjoliver
reviewed
Sep 22, 2021
hjoliver
approved these changes
Sep 22, 2021
Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
wxtim
force-pushed
the
ihs.from-platform-group
branch
from
8722f09
to
e749c26
Compare
…latform-group * 'master' of https://github.com/cylc/cylc: (101 commits) Update cylc/flow/cfgspec/workflow.py clean up interim obselete message fix flake8-simplify failures caused by recently added checks. (cylc#4420) Fix Change log Add test and raise error on src dir move change log Source symlink fix publish pending flag handle orphan tasks post reload Create window elements & load jobs from DB Deltas batched post reload Fix a doctest. Add colour to GH Actions pytest log Address review feedback. Type annotations for timer. Correct func test timeouts. Fix test. Add Cylc 7 back-compat func tests. Add stall restart func test. Func test for workflow timeout. ...
|
Strongly suggest that commits are squashed on merge. |
Comment on lines
+62
to
+74
| for host in {1..4}; do | ||
| named_grep_ok "job submit fails for bad_host${host}"\ | ||
| "\"remote-init\" failed.*\"bad_host${host}\"" \ | ||
| "$logfile" | ||
| done | ||
|
|
||
| # Look for message indicating that remote init has failed on both bad platforms | ||
| # in the platform group. | ||
| for platform in {1..2}; do | ||
| named_grep_ok "job submit fails for badplatform${platform}"\ | ||
| "badhostplatform${platform}: Tried all the hosts"\ | ||
| "$logfile" | ||
| done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes close #3827
Put up as draft - Functionally tested and probably working. Unit tests to be written.CONTRIBUTING.mdand added my name as a Code Contributor.get_platform_from_groupfunction)