-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intelligent Host Selection from Platform Group #4329
Conversation
added selection method to config for platform groups functional tests for platform from group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Had a quick look, looks good 👍 )
(Resolved a small conflict on this branch via GH UI) |
Could get coverage up a bit? |
Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
Always happy to try to do this. But there may have been reasons why I haven't. |
…ihs.from-platform-group * 'ihs.from-platform-group' of github.com:wxtim/cylc: (75 commits) Update cylc/flow/task_job_mgr.py Update cylc/flow/exceptions.py Add unit test. update cfgspec doc Cycle point format colon restriction Codecov: use flags for fast & functional tests Remove :cylc:conf: Attempt to infer run number if there is no runN symlink. (cylc#4373) Update cylc/flow/cfgspec/globalcfg.py Update cylc/flow/cfgspec/globalcfg.py Added ..attention:: to localhost == scheduler host NOT ROSE_ORIG_HOST Add `versionchanged` admonitions to certain config items Add selection to global.cylc[platforms][localhost] Prevents documentation build failure. GH Actions: Update action Fix test codecov: fiddle configuration Update changelog Change 'ignore' to 'reload' for cycle point cli opts Tidy Run the container after pulling the image from GHCR ...
…ihs.from-platform-group * 'ihs.from-platform-group' of github.com:wxtim/cylc: GH Actions: Add test workflows badges to release PRs Hot fix line length. response to review. Apply suggestions from code review Apply suggestions from code review Update cylc/flow/cfgspec/globalcfg.py Added deprecation warnings in platforms section platform documentation changes cli: change list_plugins to return a string cli: remove gui from command blacklist schema: correct faulty enum
And now it says patch is 100%. I'm confused. |
Note that Codecov starts reporting coverage as soon as it receives the first uploaded report, so it will initially have the (low) fast-tests coverage only until the functional tests finish |
06d2672
to
e4494a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, need to do some heavy testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(review in process...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Releasing some pending review comments from a few days ago...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tests as working, nice 👍 No real problems found.
Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
8722f09
to
e749c26
Compare
…latform-group * 'master' of https://github.com/cylc/cylc: (101 commits) Update cylc/flow/cfgspec/workflow.py clean up interim obselete message fix flake8-simplify failures caused by recently added checks. (cylc#4420) Fix Change log Add test and raise error on src dir move change log Source symlink fix publish pending flag handle orphan tasks post reload Create window elements & load jobs from DB Deltas batched post reload Fix a doctest. Add colour to GH Actions pytest log Address review feedback. Type annotations for timer. Correct func test timeouts. Fix test. Add Cylc 7 back-compat func tests. Add stall restart func test. Func test for workflow timeout. ...
Strongly suggest that commits are squashed on merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small docs comments.
for host in {1..4}; do | ||
named_grep_ok "job submit fails for bad_host${host}"\ | ||
"\"remote-init\" failed.*\"bad_host${host}\"" \ | ||
"$logfile" | ||
done | ||
|
||
# Look for message indicating that remote init has failed on both bad platforms | ||
# in the platform group. | ||
for platform in {1..2}; do | ||
named_grep_ok "job submit fails for badplatform${platform}"\ | ||
"badhostplatform${platform}: Tried all the hosts"\ | ||
"$logfile" | ||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍾
These changes close #3827
Put up as draft - Functionally tested and probably working. Unit tests to be written.CONTRIBUTING.md
and added my name as a Code Contributor.get_platform_from_group
function)