-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs.review spec docs #4473
Merged
Merged
Docs.review spec docs #4473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc3cbbe
to
c8ed5cc
Compare
…w-spec-docs * 'master' of https://github.com/cylc/cylc: (27 commits) Func test fix. Style fix. Update cylc/flow/cfgspec/workflow.py hopefully fixed a test and another test test. fix fix test. again another test where UTC mode=default broke fix test test - k/xtriggers/00 fix k/special/0[58]- test: fix k/special/06 test: fix k/special/04 fix broken test fix unit testing update CHANGES.md add functional test for timezone -setting Cylc 8 timezone defaults to UTC test - k/xtriggers/00 fix k/special/0[58]- ...
wxtim
commented
Oct 26, 2021
wxtim
commented
Oct 26, 2021
MetRonnie
reviewed
Nov 2, 2021
MetRonnie
reviewed
Nov 2, 2021
wxtim
commented
Nov 3, 2021
wxtim
commented
Nov 3, 2021
wxtim
commented
Nov 3, 2021
wxtim
commented
Nov 3, 2021
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
MetRonnie
reviewed
Nov 3, 2021
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
wxtim
commented
Nov 4, 2021
wxtim
commented
Nov 4, 2021
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
MetRonnie
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚀
datamel
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks, I have checked the lastest changes and will merge.
Thanks @wxtim!
This was referenced Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhaul of the config files, including responses to #4342
workflow.py
andglobalconfig.py
fixing:..versionchanged
&..versionadded
reset_bad_hosts
mainloop plugin and added it to the list of built-in mainloop plugins.[When finished] These changes close #4342 & #4091
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.py
andconda-environment.yml
.