Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove burninated flake8 code #6022

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Remove burninated flake8 code #6022

merged 1 commit into from
Mar 15, 2024

Conversation

MetRonnie
Copy link
Member

Closes #5931

B038 has been changed to an optional "opinionated" warning B909 - PyCQA/flake8-bugbear#456

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • No tests needed
  • No changelog needed
  • No docs needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added this to the cylc-8.2.5 milestone Mar 14, 2024
@MetRonnie MetRonnie requested a review from wxtim March 14, 2024 14:03
@MetRonnie MetRonnie self-assigned this Mar 14, 2024
@MetRonnie MetRonnie linked an issue Mar 14, 2024 that may be closed by this pull request
@MetRonnie MetRonnie merged commit 024b4c2 into cylc:8.2.x Mar 15, 2024
9 of 25 checks passed
@MetRonnie MetRonnie deleted the flake8 branch March 15, 2024 10:51
wxtim added a commit to wxtim/cylc that referenced this pull request Mar 28, 2024
* upstream/master: (25 commits)
  Log subprocpool stdout/stderr at debug level
  Refactor run mode restart check to avoid unclosed DB connection
  Docs: add version-added admonition [skip ci]
  Hilary review 2
  change log entry generated
  Reimplement xtrigger `sequential` arg post-merge & add tests
  hold spawn on multi seq xtrigs
  Update cylc/flow/cfgspec/workflow.py
  hilary review changes
  Integration tests added
  Review fixes 2
  tests added
  review fixes
  handle restart/reload/remove
  add sequential arg option with wall_clock default True
  default reversed, xtrigger argument added
  parentless sequential xtrigger spawning
  Preserve n-window depth on reload
  Fix type annotation & tidy (cylc#6027)
  Remove burninated flake8 code (cylc#6022)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flake8: Turn on B038
2 participants