-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow subscriptions when the hub user != uis user #679
Comments
* closes cylc#679 * the authenticated user is the one who is viewing the app * the owner is the account under which the UIS is running * if running the UIS as a standalone app the two are the same * if spawning the UIS via a hub the two may differ
update: Option (2) seems to work ok. |
* closes cylc#679 * the authenticated user is the one who is viewing the app * the owner is the account under which the UIS is running * if running the UIS as a standalone app the two are the same * if spawning the UIS via a hub the two may differ
@oliver-sanders realized just now that #724 appears to be related to this issue? Let me know if that PR is unnecessary with this new owner field in the UIS. Or if that approach could still be used (happy to close that PR if it'd be better to use the owner attribute in some way). |
Sorry, I'm falling behind with reviewing at the moment, haven't got around to #724 yet. The tricky thing with the Jupyter Server conversion is dealing with standalone UI servers that use token authentication rather than JupyterHub. |
The user from the store is used to construct the workflow ID for the tree view subscription:
cylc-ui/src/mixins/treeview.js
Line 39 in 2042834
This is fine so long as the user viewing the UI is the same as the user running the workflow.
However, the user in the store is the authenticated user which may be different. We need to capture and store the workflow owner somewhere so it can be used for this purpose later.
Note that the Jupyter Server plan (cylc/cylc-uiserver#219) means that we cannot get the workflow owner from the URL as that would only work when the UIS is run via the hub and not when it is run standalone.
Ideas:
User
field to the GraphQL schema.owner
field to the userprofile.I may try (2) as part of cylc/cylc-uiserver#219 as it should be quick.
Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read
CONTRIBUTING.md
before starting any work though).The text was updated successfully, but these errors were encountered: