-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency graphql to v16 #1022
Conversation
008aa44
to
6e8075c
Compare
Don't know if addressing #1028 would fix the test failures |
Ive extensively investigated this issue and I don't think its feasible to update at this point. The update to GraphQL v16 wont work as is because the dependency on "https://github.com/apollographql/graphql-tag" is out of date, and the replacement using createSchema (built into graphql) wont work ether as we haven't properly defined definitions for Delta, Added, Updated and Workflow (and possibly more I didn't catch), or Bruno did somehow but the definitions are not tripping the SLD validation library. Unfortunately updating the subscription-transport-ws library didn't seem to have any impact, and I cant investigate further while the invalid AST error persists (which wont go away unless we replace the gql library we are using with the updated graphql v16 one, breaking the validation library. |
Ouch, so how do we get this unblocked, in due course? |
6e8075c
to
2471371
Compare
2471371
to
7195bd7
Compare
7195bd7
to
5d77f04
Compare
3decd1b
to
0acceff
Compare
ebe3862
to
70880e9
Compare
70880e9
to
1b2c6d0
Compare
43ba9ba
to
3b9a88d
Compare
4e1f893
to
454df12
Compare
454df12
to
93f95f9
Compare
e32e897
to
9db8d6e
Compare
674e0f7
to
5e720d3
Compare
8339dd6
to
886d722
Compare
Tests are passing now? 🤷♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested out with real Cylc workflows and everything seems to work. Don't know if the problems previously faced were Webpack related, but it seems fine with Vue 3 / Vite.
886d722
to
eb6a87b
Compare
OK, seems to work for me too. |
This PR contains the following updates:
~15.8.0
->~16.6.0
Release Notes
graphql/graphql-js
v16.6.0
Compare Source
v16.6.0 (2022-08-16)
New Feature 🚀
Bug Fix 🐞
Committers: 2
v16.5.0
Compare Source
v16.5.0 (2022-05-09)
New Feature 🚀
Committers: 1
v16.4.0
Compare Source
v16.4.0 (2022-04-25)
New Feature 🚀
Bug Fix 🐞
Docs 📝
2 PRs were merged
Polish 💅
3 PRs were merged
Internal 🏠
26 PRs were merged
Dependency 📦
2 PRs were merged
Committers: 7
v16.3.0
Compare Source
v16.3.0 (2022-01-26)
New Feature 🚀
getArgumentValues
as public API (@IvanGoncharov)Bug Fix 🐞
Docs 📝
2 PRs were merged
Polish 💅
7 PRs were merged
Internal 🏠
5 PRs were merged
Dependency 📦
4 PRs were merged
Committers: 6
v16.2.0
: v16.2.0Compare Source
v16.2.0 (2021-12-17)
New Feature 🚀
resolve*Thunk
functions (@IvanGoncharov)Docs 📝
Polish 💅
Internal 🏠
2 PRs were merged
Committers: 2
v16.1.0
Compare Source
v16.1.0 (2021-12-07)
New Feature 🚀
Bug Fix 🐞
Docs 📝
Polish 💅
9 PRs were merged
Internal 🏠
9 PRs were merged
npm ci
&npm install
(@IvanGoncharov)Dependency 📦
4 PRs were merged
Committers: 5
v16.0.1
Compare Source
v16.0.1 (2021-11-01)
Bug Fix 🐞
Polish 💅
Internal 🏠
Committers: 1
v16.0.0
Compare Source
v16.0.0 (2021-10-28)
Breaking Change 💥
visitorKeys
argument (@IvanGoncharov)unknown
(TS) formixed
(flow) (@saihaj)*.d.ts
with sources converted to TS (@IvanGoncharov)null
fromserialize
function (@IvanGoncharov)null
fromserialize
function (@IvanGoncharov)visitorKeys
back (@ardatan)kind
(@IvanGoncharov)GraphQL*
constructors (@IvanGoncharov)any
(@IvanGoncharov)Deprecation ⚠
New Feature 🚀
getOperationRootType
(@IvanGoncharov)Bug Fix 🐞
deprecationReason
onGraphQLInputField
s (@trevor-scheer)__Directive.args(includeDeprecated:)
(@IvanGoncharov)locations
if error got nodes without locations (@IvanGoncharov)Docs 📝
5 PRs were merged
*.d.ts
: Switch comments to comment to TSDoc (@IvanGoncharov)Polish 💅
119 PRs were merged
wrap
util function in more places (@IvanGoncharov)keys
instead of undocumentedkey
(@IvanGoncharov)toJSON
call (@IvanGoncharov)lexValue
typing (@IvanGoncharov)padStart
(@IvanGoncharov)indexOf
toincludes
whenever possible (@IvanGoncharov)d.ts
can just export type (@saihaj)mixed
type (@IvanGoncharov)mapResult
(@IvanGoncharov)matchAll
instead ofRegExp.exec
(@IvanGoncharov)mixed
already includes it (@IvanGoncharov)getFieldDef
arg (@IvanGoncharov)Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.